avoid exposing asyncio.Future directly to api consumers#5765
Open
graingert wants to merge 16 commits intoTextualize:mainfrom
Open
avoid exposing asyncio.Future directly to api consumers#5765graingert wants to merge 16 commits intoTextualize:mainfrom
graingert wants to merge 16 commits intoTextualize:mainfrom
Conversation
willmcgugan
requested changes
May 11, 2025
Member
willmcgugan
left a comment
There was a problem hiding this comment.
Fine in principle. Just some requests.
graingert
commented
May 11, 2025
graingert
commented
May 11, 2025
graingert
commented
Dec 14, 2025
…ing-futures-directly-to-consumers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids exposing an 'asyncio.Future' to api consumers - instead returning an awaitable object wrapping an Event and a Result.
Please review the following checklist.
I didn't see any documentation for this feature outside docstrings, it's probably worth a note in the changelog