Open
Conversation
ROgbonna1
reviewed
Mar 30, 2020
Contributor
ROgbonna1
left a comment
ROgbonna1
left a comment
There was a problem hiding this comment.
There are many small errors and styling issues here. Slow down and run these in psql so that you ensure that you catch these next time.
| @@ -0,0 +1,16 @@ | |||
| SELECT count(*id) AS exact_count FROM film; | |||
Contributor
There was a problem hiding this comment.
Suggested change
| SELECT count(*id) AS exact_count FROM film; | |
| SELECT count(fid) AS exact_count FROM film_list; |
| @@ -0,0 +1,16 @@ | |||
| SELECT count(*id) AS exact_count FROM film; | |||
|
|
|||
| SELECT title,description From film ORDER BY length(description) Limit 10; | |||
Contributor
There was a problem hiding this comment.
Suggested change
| SELECT title,description From film ORDER BY length(description) Limit 10; | |
| SELECT title, description FROM film_list ORDER BY length(description) LIMIT 10; |
|
|
||
| SELECT title,description From film ORDER BY length(description) Limit 10; | ||
|
|
||
| SELECT title FROM film min(length) limit 1; |
Contributor
There was a problem hiding this comment.
Suggested change
| SELECT title FROM film min(length) limit 1; | |
| SELECT title FROM film_list min(length) LIMIT 1; |
|
|
||
| SELECT title FROM film min(length) limit 1; | ||
|
|
||
| SELECT title,description FROM film_where WHERE actors LIKE '%CAMERON STREEP%'; |
Contributor
There was a problem hiding this comment.
Suggested change
| SELECT title,description FROM film_where WHERE actors LIKE '%CAMERON STREEP%'; | |
| SELECT title, description FROM film_where WHERE actors LIKE '%CAMERON STREEP%'; |
| SELECT title,description FROM film_where WHERE actors LIKE '%CAMERON STREEP%'; | ||
|
|
||
| SELECT category AS "Genre", avg(price) AS "Average Price", avg(length) AS "Average Length" | ||
| FROM film GROUP BY category; |
Contributor
There was a problem hiding this comment.
Suggested change
| FROM film GROUP BY category; | |
| FROM film_list GROUP BY category; |
| SELECT category AS "Genre", avg(price) AS "Average Price", avg(length) AS "Average Length" | ||
| FROM film GROUP BY category; | ||
|
|
||
| SELECT rating AS "Ratings", count(rating) AS "Count" FROM film GROUP BY |
Contributor
There was a problem hiding this comment.
Suggested change
| SELECT rating AS "Ratings", count(rating) AS "Count" FROM film GROUP BY | |
| SELECT rating AS "Ratings", count(rating) AS "Count" FROM film GROUP BY rating; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.