Open
Conversation
Author
|
All problem has been solved. |
thuyanduong
reviewed
Sep 29, 2020
Member
There was a problem hiding this comment.
Good Job, Segun!
You've improved the grammar for the first sentence in README.md. You also fixed the bug in the helloworld() function in the helloworld.js file.
There are a few more improvements that could be made to this repository:
- the function
helloNamein thehelloworld.jsfile should take a parameter of name. You did not need to declarelet name = 'Ann'. Instead, the function should be coded as
function helloName(name){
console.log(`Hello, ${name}`)
}
- In the
README.md, the function descriptions are not complete sentences or have some grammatical errors. - The header "Instrcutions" is misspelled in
README.md. - The numbered list under "Instructions" has some errors. The first word of a sentence should be capitalized in "fork" and the misspelling of your as "ur".
Author
|
Thank you
…On Tue, Sep 29, 2020 at 6:01 PM Ann Duong ***@***.***> wrote:
***@***.**** commented on this pull request.
Good Job, Segun!
You've improved the grammar for the first sentence in README.md. You also
fixed the bug in the helloworld() function in the helloworld.js file.
There are a few more improvements that could be made to this repository:
- the function helloName in the helloworld.js file should take a
parameter of name. You did not need to declare let name = 'Ann'.
Instead, the function should be coded as
function helloName(name){
console.log(`Hello, ${name}`)
}
- In the README.md, the function descriptions are not complete
sentences or have some grammatical errors.
- The header "Instrcutions" is misspelled in README.md.
- The numbered list under "Instructions" has some errors. The first
word of a sentence should be capitalized in "fork" and the misspelling of
your as "ur".
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARDTTNBV42CKUP3AOLCBNU3SIJKKHANCNFSM4RYWNVHQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README.md file has been updated and the helloworld.js has been fixed