Skip to content

Updated fixes#1

Open
segunsub wants to merge 2 commits intoThe-Marcy-Lab-School:masterfrom
segunsub:master
Open

Updated fixes#1
segunsub wants to merge 2 commits intoThe-Marcy-Lab-School:masterfrom
segunsub:master

Conversation

@segunsub
Copy link

The README.md file has been updated and the helloworld.js has been fixed

@segunsub
Copy link
Author

All problem has been solved.

Copy link
Member

@thuyanduong thuyanduong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job, Segun!

You've improved the grammar for the first sentence in README.md. You also fixed the bug in the helloworld() function in the helloworld.js file.

There are a few more improvements that could be made to this repository:

  • the function helloName in the helloworld.js file should take a parameter of name. You did not need to declare let name = 'Ann'. Instead, the function should be coded as
function helloName(name){
  console.log(`Hello, ${name}`)
}
  • In the README.md, the function descriptions are not complete sentences or have some grammatical errors.
  • The header "Instrcutions" is misspelled in README.md.
  • The numbered list under "Instructions" has some errors. The first word of a sentence should be capitalized in "fork" and the misspelling of your as "ur".

@segunsub
Copy link
Author

segunsub commented Sep 30, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants