Made some improvements to README.md and bugfixes to helloWorld.js#5
Open
ShemarG wants to merge 2 commits intoThe-Marcy-Lab-School:masterfrom
Open
Made some improvements to README.md and bugfixes to helloWorld.js#5ShemarG wants to merge 2 commits intoThe-Marcy-Lab-School:masterfrom
ShemarG wants to merge 2 commits intoThe-Marcy-Lab-School:masterfrom
Conversation
thuyanduong
approved these changes
Sep 29, 2020
Member
thuyanduong
left a comment
thuyanduong
left a comment
There was a problem hiding this comment.
Great job, Shemar!
You improved the both the helloworld.js file and the README.md! You've encouraged the original writer of this repository to not just be grammatically correct in the README.md, but also descriptive and clear with their language. You've even added comments to explain your correction to their code.
And yes, the reason the original code was not working was because of the errors you have now corrected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.