Open
Conversation
thuyanduong
approved these changes
Sep 29, 2020
Member
thuyanduong
left a comment
thuyanduong
left a comment
There was a problem hiding this comment.
Great job, Jason!
You've fixed some of the grammatical mistakes in the README.md, and you've fixed the bugs and improved the code in helloworld.js!
To make further improvements, remove the comments in helloworld.js. Since you've updated the code, the comment are no longer valid. Good job adding the semicolons. Also, there are a few more capitalization errors in the README.md. We always want to speak in complete and gramatically correct sentences when possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed basic grammar mistakes but I can't spell either so it's just now coming to my mind to check the spelling just in case.
Alright, I've checked and I think I didn't make any spelling mistakes but the commit says I misspelt hello when it was actually the word instructions.