CodeQL Potential use after free fix#1024
Open
NullVerdict wants to merge 4 commits intoTheAssemblyArmada:vanillafrom
Open
CodeQL Potential use after free fix#1024NullVerdict wants to merge 4 commits intoTheAssemblyArmada:vanillafrom
NullVerdict wants to merge 4 commits intoTheAssemblyArmada:vanillafrom
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Fix code scanning alert no. 96: Potential use after free
Collaborator
|
Have you tested this with address sanitizer or valgrind to check if this doesn´t introduce any memory leaks? |
OmniBlade
approved these changes
Nov 14, 2025
Contributor
OmniBlade
left a comment
OmniBlade
left a comment
There was a problem hiding this comment.
This looks legit, only reason it doesn't blow up is because these objects are allocated off the games heap classes so the memory is still actually allocated to the game.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL detected errors like Potential use after free. I recommend integrating CodeQL into your development process to detect and fix many more such vulnerabilities.