Skip to content

Conversation

@OmniBlade
Copy link
Contributor

No description provided.

@OmniBlade OmniBlade force-pushed the feature/installer branch from 54ac965 to 908312c Compare July 22, 2021 23:06
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.10)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message should also say that it bumped cmake to version 3.14 from version 3.10.

@giulianobelinassi
Copy link
Collaborator

Debian package extract the contents into /usr/local/bin, which is binaries specifically created by the user. Instead, since this is a game, it should go on /usr/games/

@OmniBlade OmniBlade force-pushed the feature/installer branch 2 times, most recently from 70ce0e9 to 6106afd Compare July 23, 2021 21:39
@OmniBlade
Copy link
Contributor Author

I wasn't actually familiar with the existence of /usr/games and looks like its use is somewhat varied between distros, but you are right, ubuntu seems to put games in /usr/games.

@OmniBlade OmniBlade force-pushed the feature/installer branch 8 times, most recently from 35ac455 to 1e9cb29 Compare July 27, 2021 19:45
Bumps minimum cmake version to 3.14.
Bumps mingw runner to 20.04 for newer NSIS.
@OmniBlade OmniBlade force-pushed the feature/installer branch from 1e9cb29 to c6caa93 Compare July 30, 2021 10:29
@OmniBlade
Copy link
Contributor Author

PR broken due to unlinking with EA repo, see #716

@OmniBlade OmniBlade closed this Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants