Fix fmt dependency version mismatch in CMakeLists.txt#194
Merged
TheLartians merged 2 commits intoTheLartians:masterfrom Dec 22, 2024
Merged
Fix fmt dependency version mismatch in CMakeLists.txt#194TheLartians merged 2 commits intoTheLartians:masterfrom
TheLartians merged 2 commits intoTheLartians:masterfrom
Conversation
TheLartians
approved these changes
Dec 21, 2024
Owner
TheLartians
left a comment
TheLartians
left a comment
There was a problem hiding this comment.
Good catch, thanks for the fix!
Contributor
Author
|
@TheLartians No problem :) Is there any action you need me to do about the expected build status report? Sorry, I usually work with GitLab |
Owner
|
@brtmax all good, I could add another commit which apparently enabled the button for triggering the CI. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a dependency version mismatch in the CMakeLists.txt file for the fmt library. Specifically, the version of fmt specified in the CPMAddPackage section (v10.2.1) was not aligned with the version specified in the packageProject section (v9.1.0). This fix updates the packageProject dependencies to match the correct version (v10.2.1).