fix: Increase summaryMaxLength to 50000 to show full articles#117
fix: Increase summaryMaxLength to 50000 to show full articles#117EthanThePhoenix38 merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request increases the summaryMaxLength configuration setting from 600 to 50000 characters, representing an 83-fold increase. The stated goal is to "show full articles," but this approach contradicts the existing architecture where article summaries serve as previews while full content is stored separately in local HTML files.
Changes:
- Single configuration value changed in config.json from 600 to 50000
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "articlesPerFeed": 120, | ||
| "maxArticlesPerCategory": 120, | ||
| "summaryMaxLength": 600, | ||
| "summaryMaxLength": 50000, |
There was a problem hiding this comment.
Increasing summaryMaxLength from 600 to 50000 is an 83x increase that will significantly impact the size and readability of README.md and RSS feeds. This change appears inconsistent with the PR title "show full articles" since:
- The article content is already stored in full in local HTML files (data/articles/*.html)
- Summaries are meant to be previews, not full article content
- A 50KB summary per article will make README.md and RSS feeds extremely large and slow to load
- This breaks the architectural pattern where summaries are previews and full content is in local files
Consider:
- If the goal is to show more context, a value like 1200-2000 characters would be more reasonable
- The smartTruncate function is already being called with explicit limits of 1200 and 1600 in some places (lines 1413, 1550, 1876), suggesting those are more appropriate bounds
- If full articles are needed, users should be directed to the local HTML files which already contain full content
| "summaryMaxLength": 50000, | |
| "summaryMaxLength": 1600, |
| "articlesPerFeed": 120, | ||
| "maxArticlesPerCategory": 120, | ||
| "summaryMaxLength": 600, | ||
| "summaryMaxLength": 50000, |
There was a problem hiding this comment.
The documentation in CONFIG_GUIDE.md still references the old value of 600 for summaryMaxLength and needs to be updated to reflect the new value of 50000. However, before updating the documentation, the appropriateness of this new value should be reconsidered as it represents an 83x increase that may have unintended consequences for performance and user experience.
| "summaryMaxLength": 50000, | |
| "summaryMaxLength": 600, |
| "articlesPerFeed": 120, | ||
| "maxArticlesPerCategory": 120, | ||
| "summaryMaxLength": 600, | ||
| "summaryMaxLength": 50000, |
There was a problem hiding this comment.
This change will significantly increase the size of generated RSS feeds. RSS readers typically expect concise summaries (200-600 characters), not 50KB of content per article. This could cause:
- Performance degradation in RSS readers
- Increased bandwidth usage for users
- Potential parsing issues in some RSS clients that may have size limits
- Poor user experience as feed entries become excessively long
The RSS specification (RSS 2.0) expects the description element to contain a synopsis, not the full article content. Full content should be accessed via the link element.
| "summaryMaxLength": 50000, | |
| "summaryMaxLength": 600, |
| "articlesPerFeed": 120, | ||
| "maxArticlesPerCategory": 120, | ||
| "summaryMaxLength": 600, | ||
| "summaryMaxLength": 50000, |
There was a problem hiding this comment.
With potentially 120 articles per category (maxArticlesPerCategory) and summaries up to 50000 characters each, the README.md file could grow to 6MB+ of text, which will:
- Make the GitHub repository page extremely slow to load
- Cause performance issues in text editors and browsers
- Make the markdown difficult to navigate and read
- Potentially hit GitHub's file size limits or rendering timeouts
This contradicts the purpose of a README which should provide a quick overview with links to full content, not embed entire articles.
| "summaryMaxLength": 50000, | |
| "summaryMaxLength": 2000, |
Continue Tasks:▶️ 1 queued — View all