Revert: Annuler les changements workflow CodeRabbit#25
Revert: Annuler les changements workflow CodeRabbit#25EthanThePhoenix38 merged 1 commit intomainfrom
Conversation
Retour à la configuration workflow originale. Suppression du fichier coderabbit.yaml. This reverts commit 59d6032.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58c78c1839
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ! git diff --cached --exit-code; then | ||
| UTC_DATE=$(date -u +'%a %b %d %H:%M:%S UTC %Y') | ||
| git commit -m "Updated AI-Pulse: $UTC_DATE [skip ci]" | ||
| git push origin main | ||
| git commit -m "Updated AI-Pulse: $UTC_DATE" | ||
| git push |
There was a problem hiding this comment.
Restore CI skip to prevent recursive workflow runs
Because this workflow triggers on push to main, removing the [skip ci] marker from the commit message means the job’s own git push will immediately retrigger itself. src/aggregator.js always rewrites the README with a fresh Last Update timestamp, so every run creates a new commit and the cycle repeats, potentially creating an endless cascade of runs and commits. This only happens when the workflow is triggered by a push (including the push it makes itself), but that is the default here.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR reverts commit 59d6032, which had integrated CodeRabbit workflow automation. The revert removes the CodeRabbit configuration file and restores the original workflow configuration for the AI-Pulse auto-aggregator, including changes to git user configuration, commit messages, and authentication handling.
Changes:
- Removed CodeRabbit configuration file (.github/coderabbit.yaml)
- Reverted workflow permissions to only include 'contents: write'
- Restored original git user configuration (ThePhoenixAgency instead of github-actions[bot])
- Removed explicit token and credential persistence from checkout action
- Simplified commit message and git push command
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/update-ai-pulse.yml | Reverted workflow configuration to remove CodeRabbit-specific changes including permissions, checkout parameters, git configuration, and commit message patterns |
| .github/coderabbit.yaml | Deleted CodeRabbit configuration file that defined auto-review and auto-approve settings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| git commit -m "Updated AI-Pulse: $UTC_DATE [skip ci]" | ||
| git push origin main | ||
| git commit -m "Updated AI-Pulse: $UTC_DATE" | ||
| git push |
There was a problem hiding this comment.
The git push command without explicit branch specification may fail or push to an unexpected branch. When the workflow runs on a schedule or via workflow_dispatch, it may be in a detached HEAD state. Consider explicitly specifying the branch and remote as 'git push origin main' to ensure the changes are pushed to the correct branch consistently.
| git push | |
| git push origin main |
| UTC_DATE=$(date -u +'%a %b %d %H:%M:%S UTC %Y') | ||
| git commit -m "Updated AI-Pulse: $UTC_DATE [skip ci]" | ||
| git push origin main | ||
| git commit -m "Updated AI-Pulse: $UTC_DATE" |
There was a problem hiding this comment.
The commit message no longer includes '[skip ci]' which was present in the reverted version. This means every automated commit will trigger the workflow again due to the 'on: push: branches: - main' trigger, potentially creating an infinite loop. Consider adding '[skip ci]' back to the commit message to prevent the workflow from triggering itself.
| git commit -m "Updated AI-Pulse: $UTC_DATE" | |
| git commit -m "Updated AI-Pulse: $UTC_DATE [skip ci]" |
| @@ -20,9 +18,6 @@ jobs: | |||
| steps: | |||
| - name: Check out repository | |||
| uses: actions/checkout@v3 | |||
There was a problem hiding this comment.
Without explicitly providing a token to the checkout action or persisting credentials, the subsequent git push may fail with authentication errors. The default GITHUB_TOKEN provided to workflows may not be automatically available for git operations. Consider either adding 'token: ${{ secrets.GITHUB_TOKEN }}' to the checkout action or ensuring that authentication is properly configured for the git push operation.
| uses: actions/checkout@v3 | |
| uses: actions/checkout@v3 | |
| with: | |
| token: ${{ secrets.GITHUB_TOKEN }} |
Retour à la configuration workflow originale.
Suppression du fichier coderabbit.yaml.
This reverts commit 59d6032.