Skip to content

Improve error message for missing franc-min dependency #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EthanThePhoenix38 merged 5 commits into from
Feb 14, 2026
Merged

Improve error message for missing franc-min dependency #60

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a881caa
Initial plan
Copilot Feb 5, 2026
2f99ca9
Improve error message for missing franc-min package
Copilot Feb 5, 2026
a9ef8e9
Testing complete
Copilot Feb 5, 2026
0caf286
Restore franc-min dependency that was accidentally removed during tes…
Copilot Feb 5, 2026
57e4464
Merge branch 'claude/configurable-news-reader-G1Gdx' into copilot/sub…
EthanThePhoenix38 Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/aggregator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,8 @@ try {
return langMap[code] || code;
};
} catch (e) {
// Si franc-min n'est pas installé, on utilise une fonction vide
console.error('franc-min not available, using feed-declared language only');
console.error('WARNING: franc-min package not found. Language detection will be limited to feed-declared languages only.');
console.error('To enable automatic language detection, please run: npm install');
Comment on lines +202 to +203
Copy link

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The catch (e) currently assumes any failure means franc-min is missing and logs "package not found". If require('franc-min') throws for another reason (e.g., corrupted install or unexpected runtime error), this message will be misleading and the real error will be masked. Consider checking e.code === 'MODULE_NOT_FOUND' (and that the message references franc-min) before logging this, and otherwise rethrow or log the original error details.

Suggested change
console.error('WARNING: franc-min package not found. Language detection will be limited to feed-declared languages only.');
console.error('To enable automatic language detection, please run: npm install');
if (e && e.code === 'MODULE_NOT_FOUND' && (e.message || '').includes('franc-min')) {
console.error('WARNING: franc-min package not found. Language detection will be limited to feed-declared languages only.');
console.error('To enable automatic language detection, please run: npm install');
} else {
console.error('ERROR: Failed to initialize franc-min language detection. Falling back to feed-declared languages only.');
console.error(e);
}

Copilot uses AI. Check for mistakes.
detectLang = () => null;
}

Expand Down