rebase

[EthanThePhoenix38]

---

Continue Tasks: ▶️ 1 queued — View all

[Copilot]

Pull request overview

This PR appears to be a rebase that consolidates multiple improvements including French language corrections, enhanced error handling, improved input validation, and dependency updates. However, the rebase has introduced critical bugs due to incomplete conflict resolution.

Changes:

• Corrected French accents throughout templates, config files, workflows, and issue templates
• Enhanced error handling for config loading, localStorage operations, and email sending
• Improved input validation and sanitization in GitHub workflows
• Added rate limiting for email sending and configurable sender address
• Updated dependencies (openai, lru-cache, qs, and CSS-related packages)
• Added new unsubscribe issue template
• Improved language detection with validation against ISO 639-1 codes

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
templates/email-digest.html	Fixed French accents in email template text
src/aggregator.js	CRITICAL BUG: Incomplete deduplication refactoring with undefined variables; added config error handling, email validation, rate limiting, and language validation
readme-viewer.html	Added localStorage availability checks and error handling; BUG: new setupScrollSpy function not called; removed hideRead checkbox from UI
js/tracker.js	Added localStorage availability checks and improved error handling for tracking
package.json & package-lock.json	Updated openai to 6.19.0 and various transitive dependencies
config.json	Corrected French accents in category labels and tag translations
CHANGELOG.md	Added automated security update entries with future dates (minor issue)
.github/workflows/manage-subscriber.yml	Enhanced email validation with abuse prevention and sanitization
.github/workflows/label.yml	Added issues:write permission
.github/workflows/add-source.yml	Added input validation and sanitization; minor maintainability issue with error messages
.github/ISSUE_TEMPLATE/unsubscribe.yml	CRITICAL: New template without corresponding workflow to handle unsubscription
.github/ISSUE_TEMPLATE/subscribe.yml	Corrected some French accents; still missing some on lines 1, 2, and 45
.github/ISSUE_TEMPLATE/new-source.yml	Corrected French accents in dropdown labels

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The new setupScrollSpy() function is defined but never called. It should likely be invoked during initialization in the loadReadme() function after the content is loaded, similar to how buildSectionNav() and applyFilters() are called. Without calling this function, the scroll spy feature will not be enabled.

Suggested change

	// Initialize scroll spy after the DOM is ready
	document.addEventListener('DOMContentLoaded', () => {
	setupScrollSpy();
	});

[Copilot]

A new unsubscribe issue template has been added, but there is no corresponding workflow to handle unsubscription requests. The manage-subscriber.yml workflow only handles the 'subscription' label. You need to either add a handler for the 'unsubscription' label in the existing workflow or create a new workflow to process unsubscribe requests and remove emails from the subscribers.json file.

[Copilot]

The source name sanitization check will always reject valid names that exceed MAX_SOURCE_NAME_LENGTH (100 characters) even if they contain no invalid characters. The condition if (sanitizedSourceName !== sourceName) will be true both when invalid characters are removed AND when the string is truncated. Consider separating these checks: first check for invalid characters, then check length, to provide more specific error messages to users.

[Copilot]

The French text on lines 1 and 2 still contains missing accents: "S'abonner a" should be "S'abonner à" and "personnalise" should be "personnalisé". Additionally on line 45, "mise a jour" should be "mise à jour" for consistency with the French language corrections made elsewhere in this PR.

[Copilot]

The deduplication refactoring is incomplete. While lines 452-458 introduce new variable names (threshold and normalizedTitles), the code below (lines 467-492) still references undefined variables: normalizedData (should be normalizedTitles), titleThreshold and contentThreshold (should be threshold). This will cause a runtime error when deduplication is enabled. The refactoring needs to be completed to update all references consistently.