refactor: consolidate workflows using dorny/paths-filter#59
Merged
Conversation
- Replaced separate docs-validation.yml and miscellaneous-validation.yml with single workflow - Implemented dorny/paths-filter pattern following Nextcloud/Immich approach - Added changes pre-job to detect src vs docs changes - Docs-only changes get fast check without full build/test - Config-only changes (LICENSE, .gitignore, etc.) don't require CI checks - Added concurrency control and explicit permissions - Simplified maintenance with single workflow file
There was a problem hiding this comment.
Pull request overview
Updates the PR Build and Test workflow to avoid running full build/test on documentation-only changes by using dorny/paths-filter to gate subsequent jobs.
Changes:
- Added a dedicated
changesjob that classifies PR modifications intosrcvsdocs. - Introduced a docs-only fast-path job and gated build/test execution on
srcchanges. - Added workflow-level
permissionsandconcurrencycontrols.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dorny/paths-filter needs access to base commit for PR diffs. Without fetch-depth, shallow clone only has HEAD and filter fails.
dorny/paths-filter needs pull-requests: read to query PR files via GitHub API. Following Nextcloud pattern of granting permission at job level (least privilege).
Markdown files in src/ or tests/ should not trigger full build/test. Added negation patterns (!src/**/*.md, !tests/**/*.md) so markdown changes are treated as docs-only regardless of location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
pr-build-test.ymlGitHub Actions workflow to improve efficiency and clarity by distinguishing between documentation and source code changes. The workflow now only triggers builds and tests when source code is modified, and provides a fast path for documentation-only changes.