Avoid allocating strings when formatting allocation byte-sizes#244
Avoid allocating strings when formatting allocation byte-sizes#244nical wants to merge 1 commit intoTraverse-Research:mainfrom
Conversation
MarijnS95
left a comment
There was a problem hiding this comment.
Nice, that's how it's supposed to be implemented
3d6b3a2 to
d68764b
Compare
3a5f6b1 to
0588a06
Compare
|
Seems quite coincidental that that Rust release notes suggest a nice way of writing this loop too: https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html#exclusive-ranges-in-patterns |
Nice. Is it worth the msrv bump, though? wgpu has to lag a few rustc versions behind, so I'd appreciate if we shelf the nicer version for later. |
Wasn't intending to bump just to use |
Head branch was pushed to by a user without write access
It's not particularly important but while I was adding integration in wgpu for the allocator reports and duplicating a bit of the formatting code in the process, it was rubbing me the wrong way to allocate strings in
fmt_byteswhen a Display impl could do the same without allocating, so I made the change there. Now I wrote the slightly better version, might as well contribute it back to its original spot!