-
Notifications
You must be signed in to change notification settings - Fork 0
fix: test for basicGeoWidget #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: basicGeoWidget
Are you sure you want to change the base?
Conversation
951b51f to
9f66ea6
Compare
| DATABASES = { | ||
| 'default': { | ||
| 'ENGINE': 'django.db.backends.sqlite3', | ||
| 'ENGINE': 'django.contrib.gis.db.backends.spatialite', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these database engine changes align with upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for the postgres parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the upstream a postgres or sqlite database is used.
The postgres parameters may not be fixed and therefore removed.
This PR adds an end-to-end test for the
⚠️ Make sure to use
regioncollectionand contains other relevant changes in order for this test to pass.export DATABASE_ENGINE=postgresfor the new test and the setup.Please review