fix: exit probe task promptly when client is dropped#71
Open
BugenZhao wants to merge 4 commits intoTrueLayer:mainfrom
Open
fix: exit probe task promptly when client is dropped#71BugenZhao wants to merge 4 commits intoTrueLayer:mainfrom
BugenZhao wants to merge 4 commits intoTrueLayer:mainfrom
Conversation
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of solely depending on the
ProbeError::ChangesetSenderClosedto find out whether we need to exit the probe task, check ifself.endpoint_reporter.is_closed(), so that we can promptly exit as long as the client is dropped (balance channel is closed) even if there's no change on the probing results.