Draft
Conversation
Owner
|
Hi there! First of all, I just want to say how amazing this looks- I'm genuinely impressed by what you've come up with. I'm also really intrigued by how it all works! I would definitely want this feature to be in my project so don't you worry :> My exams are going on at the moment, but I’ll definitely start working on it after June 10th. Looking forward to it! :> |
Author
|
Haha thanks! Your first image on the repo really inspired me. And good luck with finals! Here's a full write up: Changesposter.py:
prompt.py:
wallpaper.py
fixes remaining
Possible improvements
|
|
i like posters without any shadow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! First off I want to say thank your for creating such a sick utility! The example image with the three posters made me really wish there was a way to generate wallpapers like that, thus the impetus for this PR.
Understand if you're not interested in merging the changes, as it might seem like it goes beyond the scope of the project, but I thought I would put together this PR in case you are interested in the functionality!
Changes:
poster.py: Added image return to pass the generated posters into the wallpaper.py
wallpaper.py: Calculates the correct poster size to embed in the given wallpaper dimensions. Also adds a drop shadow to each poster
cli/prompt.py: Adds prompting hopefully in line with the spirit of the original program, takes in 1-10 posters to create a wallpaper from. Takes in Wallpaper dimensions, and BG color. Guides users through repeated poster creations
Currently there are a few things that need to be improved, and more documentation needs to be added, but I'd like to gauge the interest in incorporating this into the main branch before I spend further time developing this. Attached are some wallpapers generated as example.
Once again, thanks for making this great little program!!