Add support to move line edges in karaoke mode#402
Open
vonagam wants to merge 1 commit intoTypesettingTools:masterfrom
Open
Add support to move line edges in karaoke mode#402vonagam wants to merge 1 commit intoTypesettingTools:masterfrom
vonagam wants to merge 1 commit intoTypesettingTools:masterfrom
Conversation
vonagam
force-pushed
the
movable-karaoke-edges
branch
from
9c82c8a to
2513eb3
Compare
vonagam
force-pushed
the
movable-karaoke-edges
branch
from
2513eb3 to
c7f46dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use Aegisub to make karaoke videos and the most painful thing for me when working in karaoke mode is inability to move line edges. This PR adds such ability.
Right now to adjust a start of a first word you need to exit karaoke mode (which does not have a keyboard shortcut), then take note of current start time or duration of the line, then move the start, then manually adjust the time of the first word to compensate the difference in time from previous start/duration so that all other karaoke words do not move relative to previous positions, then go back to karaoke mode.
Adjusting an end of a last word is a little less painful as you don't have to do math in your head - instead of that you need to click on a green check mark once you get back to karaoke mode. (But it is still painful as it requires three additional clicks and you might forget about clicking the green check mark.)
(Also as a bonus fixed improper time auto commit that was happening with applying lead in / lead out in karaoke mode.)