Implement Wayland-compatible eyedropper using XDG Desktop Portals#535
Open
filip-hejsek wants to merge 2 commits intoTypesettingTools:masterfrom
Open
Implement Wayland-compatible eyedropper using XDG Desktop Portals#535filip-hejsek wants to merge 2 commits intoTypesettingTools:masterfrom
filip-hejsek wants to merge 2 commits intoTypesettingTools:masterfrom
Conversation
The Portal-based dropper only works if XDG Desktop Portals are installed and configured on the system and has more limited functionallity, but it can work on Wayland and is less broken than the current dropper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new XDG Desktop Portal-based eyedropper implementation for Linux.
The Portal-based dropper has the following limitations:
For the vast majority of users on Linux, this is an improvement over the current dropper, which:
Implementation notes:
Copyright (c) 2026, Aegisub contributorsand updated the project URL tohttps://aegisub.org/. I noticed the copyright notices in most files are incorrect (they were not updated when the file was modified).agi::xdp_utilsnamespace. Not sure if this matches current conventions, although existing use of namespaces seemed inconsistent to me anyway.#ifdefaroundxdg_desktop_portal_utils.cpp, even though it's unnecessary because the file is compiled conditionally. This matches how it's done in theaudio_player_*files.