Open
Conversation
cbrasfield
commented
Nov 6, 2025
| defaults: | ||
| _controller: '\Drupal\uceap_logging\Controller\FieldList::autocomplete' | ||
| requirements: | ||
| _permission: 'access content' No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
This should probably be administer site configuration
cbrasfield
commented
Nov 6, 2025
| $form['sensitive_fields'] = [ | ||
| '#type' => 'textarea', | ||
| '#title' => $this->t('Sensitive Fields'), | ||
| '#description' => $this->t('Enter field machine names (one per line) that should have their values masked in entity change logs. When these fields are modified, they will appear in logs with masked values (e.g., ***MASKED***) instead of actual values.'), |
Contributor
Author
There was a problem hiding this comment.
Description should be restored.
Member
|
OK I dig the autocomplete in general (I understand why you'd prefer select2 for UX but when I tested that branch locally the widget was missing?), however there's one big issue I discovered in testing this: base fields. If we're autocompleting only on config fields, it implies that either base fields don't work or don't exist. But we def need to support (some) base fields. I'm not sure there's a reasonable way to do that? Unless you want to extend this to a custom widget where we select an entity type first, then fields on that entity, but that sounds like a lot of work... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not as pretty as #3