Skip to content

Conversation

@ztucker4
Copy link
Contributor

@ztucker4 ztucker4 commented Oct 15, 2025

Implements SYS-2055

Uses the new function filter_by_inventory_number_and_library() from the ftva_etl package to filter Alma results. Alma search results pages and JSON metadata generation will now only use bib records from the FTVA library and with a call number matching the Digital Data inventory number (per FTVA requirements implemented in ftva_etl).

No new automated tests. For manual testing, item 20555 previously had two Alma matches, but now should show just the one associated with the FTVA library (MMS ID 991334333506533). Item 25125 demonstrates a prefix/suffix match - MMS ID 991932163506533 has a call number of VA15789 T, matching the inventory number VA15789.

Also includes release notes and tag bump for deployment.

@ztucker4 ztucker4 requested a review from akohler October 15, 2025 21:11
Copy link
Member

@akohler akohler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ztucker4 This is great, and thanks for the examples. Both work as expected now.
There was a merge conflict in release notes & version from #88 , which I went ahead and resolved since you fixed my type hint error earlier :)

Merging now, thanks --Andy

@akohler akohler merged commit 6ab15ef into main Oct 16, 2025
1 check passed
@akohler akohler deleted the SYS-2055/filter-alma-data branch October 16, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants