Skip to content

feat(ui5-color-picker): add accessibleName property for unique landmarks #12968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hinzzx wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(ui5-color-picker): add accessibleName property for unique landmarks #12968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa7b4ab
fix(ui5-color-picker): add accessibleName property for unique landmarks
hinzzx Jan 27, 2026
cc4686f
add accessibleNameRef
hinzzx Feb 2, 2026
ecb532c
Merge branch 'main' into color-picker-acc-fixes
hinzzx Feb 3, 2026
43e12e1
fix lint change
hinzzx Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion packages/main/src/ColorPicker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import jsxRenderer from "@ui5/webcomponents-base/dist/renderer/JsxRenderer.js";
import i18n from "@ui5/webcomponents-base/dist/decorators/i18n.js";
import type I18nBundle from "@ui5/webcomponents-base/dist/i18nBundle.js";
import type ValueState from "@ui5/webcomponents-base/dist/types/ValueState.js";
import { getEffectiveAriaLabelText } from "@ui5/webcomponents-base/dist/util/AccessibilityTextsHelper.js";
import type { IFormInputElement } from "@ui5/webcomponents-base/dist/features/InputElementsFormSupport.js";
import {
getRGBColor,
Expand Down Expand Up @@ -136,6 +137,24 @@ class ColorPicker extends UI5Element implements IFormInputElement {
@property({ type: Boolean })
simplified = false;

/**
* Defines the accessible name of the component.
* @default undefined
* @public
* @since 2.20.0
*/
@property()
accessibleName?: string;

/**
* Receives id(or many ids) of the elements that label the component.
* @default undefined
* @public
* @since 2.20.0
*/
@property()
accessibleNameRef?: string;

/**
* Defines the current main color which is selected via the hue slider and is shown in the main color square.
* @private
Expand Down Expand Up @@ -556,7 +575,10 @@ class ColorPicker extends UI5Element implements IFormInputElement {
}

get colorPickerLabel() {
return ColorPicker.i18nBundle.getText(COLORPICKER_LABEL);
const effectiveLabel = getEffectiveAriaLabelText(this);
return effectiveLabel
? `${ColorPicker.i18nBundle.getText(COLORPICKER_LABEL)} ${effectiveLabel}`
: ColorPicker.i18nBundle.getText(COLORPICKER_LABEL);
}

get sliderGroupLabel() {
Expand Down
4 changes: 2 additions & 2 deletions packages/main/src/ColorPickerTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import Button from "./Button.js";

export default function ColorPickerTemplate(this: ColorPicker) {
return (
<section
<div
class="ui5-color-picker-root"
role="group"
aria-label={this.colorPickerLabel}
Expand Down Expand Up @@ -132,6 +132,6 @@ export default function ColorPickerTemplate(this: ColorPicker) {
</div>
</div>
}
</section>
</div>
);
}
Loading