feat: do a main operator with user input#459
Open
LeottaAlberto wants to merge 4 commits intoUNICT-Quality-Development:mainfrom
Open
feat: do a main operator with user input#459LeottaAlberto wants to merge 4 commits intoUNICT-Quality-Development:mainfrom
LeottaAlberto wants to merge 4 commits intoUNICT-Quality-Development:mainfrom
Conversation
Member
|
codestyle fails |
Helias
reviewed
Nov 5, 2025
| float num2 = insertNumber("second"); | ||
|
|
||
| doOperation(num1, num2); | ||
| } |
Helias
reviewed
Nov 5, 2025
exercises/calculator.cpp
Outdated
| if(!isCorrect) std::cout << ERROR_COLOR+("[Insert a valid input] ")+NORMAL_COLOR; | ||
| std::cout << "Insert "<< position <<" number: "; | ||
| getline(std::cin, insert); | ||
| } while(!(isCorrect = checkStringIsNumber(insert))); |
Member
There was a problem hiding this comment.
questo ciclo do-while sembra poco leggibile, potresti aggiungere parentesi e spaziature al primo if e spezzare la condizione dentro il while nel seguente modo
...
isCorrect = checkStringIsNumber(insert)
} while(!isCorrect)
Helias
reviewed
Nov 5, 2025
exercises/calculator.cpp
Outdated
| getline(std::cin, insert); | ||
| } while(!(isCorrect = checkStringIsNumber(insert))); | ||
|
|
||
| return std::stoi(insert); |
Member
There was a problem hiding this comment.
potresti usare il namespace std per evitare di scrivere std:: nell'intero file
Helias
reviewed
Nov 5, 2025
exercises/calculator.cpp
Outdated
Comment on lines
56
to
63
| bool checkStringIsNumber(std::string in){ | ||
| if(in.empty()) return false; | ||
| if(in.size() > MAX_DIGIT) return false; | ||
| for(int i = 0; i < in.size(); i++) | ||
| if((in.at(i) < ZERO || in.at(i) > NINE) && in.at(i) != MINUS) return false; | ||
|
|
||
| return true; | ||
| } |
Member
There was a problem hiding this comment.
Gli spazi non costano, puoi usarli ;-)
Suggested change
| bool checkStringIsNumber(std::string in){ | |
| if(in.empty()) return false; | |
| if(in.size() > MAX_DIGIT) return false; | |
| for(int i = 0; i < in.size(); i++) | |
| if((in.at(i) < ZERO || in.at(i) > NINE) && in.at(i) != MINUS) return false; | |
| return true; | |
| } | |
| bool checkStringIsNumber(std::string in){ | |
| if (in.empty()) | |
| return false; | |
| if (in.size() > MAX_DIGIT) | |
| return false; | |
| for (int i = 0; i < in.size(); i++) | |
| if ((in.at(i) < ZERO || in.at(i) > NINE) && in.at(i) != MINUS) | |
| return false; | |
| return true; | |
| } |
Helias
reviewed
Nov 5, 2025
exercises/calculator.cpp
Outdated
|
|
||
| bool checkStringIsNumber(string in){ | ||
| if(in.empty()) return false; | ||
| if(in.size() > MAX_DIGIT) return false; |
Helias
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.