CuraApplication.py add startReloadAll signal when reloadAll is called#19608
Open
dfries wants to merge 2 commits intoUltimaker:mainfrom
Open
CuraApplication.py add startReloadAll signal when reloadAll is called#19608dfries wants to merge 2 commits intoUltimaker:mainfrom
dfries wants to merge 2 commits intoUltimaker:mainfrom
Conversation
Uranium/UM/Scene/Scene.py depends this startReloadAll, which it will use to cancel file modification reload dialog. Once all the models are reloaded, the file modification reload is not needed.
6 tasks
Contributor
|
Hi @dfries, thanks for this change ! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Uranium/UM/Scene/Scene.py commit "Scene.py add _hideReloadMessage, connect to startReloadAll" Uranium pull request Ultimaker/Uranium#964 depends on this commit and the signal startReloadAll, which it will
use to cancel file modification reload dialog. Once all the models
are reloaded, the file modification reload dialog is not needed.
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: