Fix asserts for called once in Python 3.12#885
Draft
hroncok wants to merge 2 commits intoUltimaker:mainfrom
Draft
Fix asserts for called once in Python 3.12#885hroncok wants to merge 2 commits intoUltimaker:mainfrom
hroncok wants to merge 2 commits intoUltimaker:mainfrom
Conversation
Contributor
hroncok
commented
Jul 9, 2023
hroncok
commented
E AttributeError: 'called_once_with' is not a valid assertion. Use a spec for the mock if 'called_once_with' is meant to be an attribute.. Did you mean: 'assert_called_once_with'?
FAILED tests/TestBackend.py::test__onSocketStateChanged_listening - Attribute...
FAILED tests/TestBackend.py::test_onSocketStateChanged_connected - AttributeE...
FAILED tests/Jobs/TestJob.py::test_start - AttributeError: 'called_once_with'...
FAILED tests/Jobs/TestJob.py::test_cancel - AttributeError: 'called_once_with...
github-actions
bot
added
the
PR: Community Contribution 👑
Contributor
Author
|
This was needed in Fedora to update to Python 3.12 (together with using https://pypi.org/project/zombie-imp/ to workaround #765). Unfortunately, one of the asserts actually failed, hence I needed to comment it out. I don't think this ever asserted anything, so perhaps it was a wrong assert... ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.