Draft
Conversation
Added 5 colors of VOXELPLA plus profiles
Added new VOXELPLA PLUS profiles
Author
|
This is my first time making a pull request. I am unsure if I am doing this correctly; please let me know if there are any issues. |
MariMakes
reviewed
Sep 22, 2022
| <label>VOXELPLA PLUS BLACK</label> | ||
| </name> | ||
| <version>8</version> | ||
| <GUID>da7d7354-792f-4e80-ac3b-59df1de531fa</GUID> |
Contributor
There was a problem hiding this comment.
These should be Unique GUIDs.
Every material should haver its own Unique Modifier.
You can get one here:
https://www.guidgenerator.com/
Comment on lines
+7
to
+8
| <color>BLACK</color> | ||
| <label>VOXELPLA PLUS BLACK</label> |
Contributor
There was a problem hiding this comment.
Please only capitalize what needs capitalization.
Here I would suggest
Suggested change
| <color>BLACK</color> | |
| <label>VOXELPLA PLUS BLACK</label> | |
| <color>Black</color> | |
| <label>VOXELPLA PLA Plus Black</label> | |
| <version>8</version> | ||
| <GUID>da7d7354-792f-4e80-ac3b-59df1de531fa</GUID> | ||
| <color_code>#000000</color_code> | ||
| <description>The most reliable PLA PLUS on the planet. Best printed with 200C on the extruder and 45-60C on the bed, minimal retraction is needed. Each spool is $16.99 on WWW.VOXELPLA.COM</description> |
Contributor
There was a problem hiding this comment.
This description is not helpful for users.
The bold claim that this is The Most Reliable PLA PLUS on the planet cannot be fact-checked.
Including the price and website is not a good idea since it's subject to change and can only be updated when shipped with a Cura release.
I suggest removing these mentions and making them a more nuanced message.
| </properties> | ||
| <settings> | ||
| <setting key="print temperature">200</setting> | ||
| <setting key="heated bed temperature">60</setting> |
Contributor
There was a problem hiding this comment.
Most the printers that you included seem to have a heated bed temperature of 55.
If you change this value to
Suggested change
| <setting key="heated bed temperature">60</setting> | |
| <setting key="heated bed temperature">55</setting> |
Then you can remove all the mentions of heated bed temperature in the printers and you adhere to the DRY principle:
https://www.plutora.com/blog/understanding-the-dry-dont-repeat-yourself-principle
Comment on lines
+27
to
+250
| <machine> | ||
| <machine_identifier manufacturer="Tronxy" product="tronxy_xy3proV2" /> | ||
| <setting key="heated bed temperature">55</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Tronxy" product="tronxy_xy3" /> | ||
| <setting key="heated bed temperature">55</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Tronxy" product="tronxy_xy2pro" /> | ||
| <setting key="heated bed temperature">55</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Tronxy" product="tronxy_xy2" /> | ||
| <setting key="heated bed temperature">55</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Tronxy" product="tronxy_x5sa_500" /> | ||
| <setting key="heated bed temperature">55</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Tronxy" product="tronxy_x5sa_400" /> | ||
| <setting key="heated bed temperature">55</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Tronxy" product="tronxy_x5sa" /> | ||
| <setting key="heated bed temperature">55</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Tronxy" product="tronxy_x" /> | ||
| <setting key="heated bed temperature">55</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Tronxy" product="tronxy_d01" /> | ||
| <setting key="heated bed temperature">55</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Lotmaxx" product="lotmaxx_sc60" /> | ||
| <setting key="heated bed temperature">50</setting> | ||
| <setting key="standby temperature">200</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Kati Hal ARGE" product="kupido" /> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| <setting key="retraction speed">40</setting> | ||
| <setting key="retraction amount">0.8</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="IMADE3D" product="IMADE3D JellyBOX" /> | ||
| <setting key="print temperature">210</setting> | ||
| <setting key="heated bed temperature">55</setting> | ||
| <hotend id="0.4 mm"> | ||
| <setting key="hardware compatible">yes</setting> | ||
| </hotend> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Creality3D" product="creality_ender5" /> | ||
| <setting key="heated bed temperature">50</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| <setting key="retraction speed">60</setting> | ||
| <setting key="retraction amount">5</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Creality3D" product="creality_ender4" /> | ||
| <setting key="heated bed temperature">50</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| <setting key="retraction speed">60</setting> | ||
| <setting key="retraction amount">5</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Creality3D" product="creality_ender3" /> | ||
| <setting key="heated bed temperature">50</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| <setting key="retraction speed">60</setting> | ||
| <setting key="retraction amount">5</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Creality3D" product="creality_ender2" /> | ||
| <setting key="heated bed temperature">50</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| <setting key="retraction speed">60</setting> | ||
| <setting key="retraction amount">5</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Creality3D" product="creality_cr20pro" /> | ||
| <setting key="heated bed temperature">50</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| <setting key="retraction speed">60</setting> | ||
| <setting key="retraction amount">5</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Creality3D" product="creality_cr20" /> | ||
| <setting key="heated bed temperature">50</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| <setting key="retraction speed">60</setting> | ||
| <setting key="retraction amount">5</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Creality3D" product="creality_cr10spro" /> | ||
| <setting key="heated bed temperature">50</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| <setting key="retraction speed">60</setting> | ||
| <setting key="retraction amount">5</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Creality3D" product="creality_cr10s5" /> | ||
| <setting key="heated bed temperature">50</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| <setting key="retraction speed">60</setting> | ||
| <setting key="retraction amount">5</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Creality3D" product="creality_cr10s4" /> | ||
| <setting key="heated bed temperature">50</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| <setting key="retraction speed">60</setting> | ||
| <setting key="retraction amount">5</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Creality3D" product="creality_cr10s" /> | ||
| <setting key="heated bed temperature">50</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| <setting key="retraction speed">60</setting> | ||
| <setting key="retraction amount">5</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Creality3D" product="creality_cr10mini" /> | ||
| <setting key="heated bed temperature">50</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| <setting key="retraction speed">60</setting> | ||
| <setting key="retraction amount">5</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Creality3D" product="creality_cr10" /> | ||
| <setting key="heated bed temperature">50.0</setting> | ||
| <setting key="standby temperature">180.0</setting> | ||
| <setting key="print cooling">100</setting> | ||
| <setting key="retraction speed">60.0</setting> | ||
| <setting key="retraction amount">5.0</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="CreawsomeMod" product="creality_base" /> | ||
| <setting key="heated bed temperature">50</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| <setting key="retraction speed">60</setting> | ||
| <setting key="retraction amount">5</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Cartesio bv" product="cartesio" /> | ||
| <setting key="print temperature">190</setting> | ||
| <setting key="heated bed temperature">43</setting> | ||
| <setting key="standby temperature">160</setting> | ||
| <setting key="print cooling">40.0</setting> | ||
| <setting key="retraction speed">40</setting> | ||
| <hotend id="0.8mm thermoplastic extruder"> | ||
| <setting key="hardware compatible">yes</setting> | ||
| <setting key="retraction amount">1.5</setting> | ||
| </hotend> | ||
| <hotend id="0.4mm thermoplastic extruder"> | ||
| <setting key="hardware compatible">yes</setting> | ||
| <setting key="retraction amount">1.0</setting> | ||
| </hotend> | ||
| <hotend id="0.25mm thermoplastic extruder"> | ||
| <setting key="hardware compatible">yes</setting> | ||
| <setting key="retraction amount">1.0</setting> | ||
| </hotend> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="BIQU" product="biqu_b1_abl" /> | ||
| <setting key="print temperature">180</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="BIQU" product="biqu_b1" /> | ||
| <setting key="print temperature">180</setting> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Kati Hal ARGE" product="alyanx3dp" /> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| <setting key="retraction speed">40</setting> | ||
| <setting key="retraction amount">1.5</setting> | ||
| </machine> | ||
| <machine> | ||
| <machine_identifier manufacturer="Kati Hal ARGE" product="alya3dp" /> | ||
| <setting key="standby temperature">180</setting> | ||
| <setting key="print cooling">100</setting> | ||
| <setting key="retraction speed">40</setting> | ||
| <setting key="retraction amount">1.5</setting> | ||
| </machine> |
Contributor
There was a problem hiding this comment.
You do not have to repeat every printer definition if the settings are the same.
If you check:
https://github.com/Ultimaker/fdm_materials/blob/master/redd_pla.xml.fdm_material
You can see that they removed the machine definitions and it's still available for all 1.75 printers in Cura.
If you know the specific settings of each printer and they are indeed different, you should keep them in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added 5 new colors of VOXELPLA with retraction and temp setting for the filament