Some context menu changes for the main tree view#1973
Open
LukeUniverse wants to merge 2 commits intoUnderminersTeam:masterfrom
Open
Some context menu changes for the main tree view#1973LukeUniverse wants to merge 2 commits intoUnderminersTeam:masterfrom
LukeUniverse wants to merge 2 commits intoUnderminersTeam:masterfrom
Conversation
Discussed with some people in the discord server, and they encouraged me to make a PR, so uh, this is my attempt at that.
Adds a few things to the right click context menu of the treeview:
New items I added:
<Seperator/>
Move up to {Previous Section}
Move down to {Next Section}
<Seperator/>
Collapse all
Collapse {Current Section}
<Seperator/>
Add: {CurrentSection}
Where Current/Previous/Next Section is replaced with the text of the that section such as "Sounds" "Tile sets" "Sprites", etc etc.
oops this should have been with the previous check in
Miepee
reviewed
Nov 25, 2024
Contributor
Miepee
left a comment
Miepee
left a comment
There was a problem hiding this comment.
Heads up: for GUI changes, screenshots are always nice to have :)
Also for the future, if you're doing just visual ordering, make these in seperate commits please so that it's easier to review
Comment on lines
+263
to
+264
| <MenuItem Header="Move up to" Click="MenuItem_MoveUpTo_Click"/> | ||
| <MenuItem Header="Move down to" Click="MenuItem_MoveDownTo_Click"/> |
Contributor
There was a problem hiding this comment.
What are these supposed to do?
|
Download the artifacts for this pull request here: GUI:
CLI: |
Miepee
requested changes
Nov 25, 2024
| if (Highlighted is UndertaleObject obj) | ||
| DeleteItem(obj); | ||
| } | ||
| //this 99% copied from the the Add_Click, so could probably have the fuctionality of it (and above) combined into one method that then gets called from both events) |
Contributor
There was a problem hiding this comment.
please don't copy paste for 90%
Also because I cant find it right now, whats the difference between Add and AddType ?
Comment on lines
+2082
to
+2084
| foreach (TreeViewItem treeItem in (MainTree.Items[0] as TreeViewItem).Items) | ||
| if (treeItem.Items.Contains(MainTree.SelectedItem)) | ||
| indexOfCurrentSelectionParent = (MainTree.Items[0] as TreeViewItem).Items.IndexOf(treeItem); |
Contributor
There was a problem hiding this comment.
please refer to our code style
use braces
Comment on lines
+2188
to
+2190
| foreach (TreeViewItem item in (MainTree.Items[0] as TreeViewItem).Items) | ||
| if (item.Items.Contains(MainTree.SelectedItem)) | ||
| item.IsExpanded = false; |
Comment on lines
+2182
to
+2183
| foreach (TreeViewItem item in (MainTree.Items[0] as TreeViewItem).Items) | ||
| item.IsExpanded = false; |
Comment on lines
+2197
to
+2198
| //LMM: Regarding the text changes, and visibility changes here... there is most likely better ways to do this, I'm not super familair with XAML though, and eh, this worked for me. | ||
| //other contributors could polish this up if need be :) |
Contributor
There was a problem hiding this comment.
code style: please have a space after the // and start with an uppercase letter
What does LMM mean?
Also CC @VladiStep cause you probably know more xaml than anyone else on the dev team.
Comment on lines
+2353
to
+2356
| foreach (TreeViewItem item in (MainTree.Items[0] as TreeViewItem).Items) | ||
| if (item.Items.Contains(MainTree.SelectedItem)) | ||
| indexOfCurrentSelectionParent = (MainTree.Items[0] as TreeViewItem).Items.IndexOf(item); | ||
|
|
Comment on lines
+2363
to
+2365
| foreach (TreeViewItem treeItem in (MainTree.Items[0] as TreeViewItem).Items) | ||
| if (treeItem.Items.Contains(MainTree.SelectedItem)) | ||
| indexOfCurrentSelectionParent = (MainTree.Items[0] as TreeViewItem).Items.IndexOf(treeItem); |
| item.IsExpanded = false; | ||
| } | ||
|
|
||
| private void MenuItem_ContextMenuOpened(object sender, RoutedEventArgs e) |
Contributor
There was a problem hiding this comment.
please double check codestyle in this whole function, not gonna point it out in every instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a few options to the right click context menu for the TreeView on the left hand side of the screen.
New items I added:
Move up to {Previous Section}
Move down to {Next Section}
Collapse all
Collapse {Current Section}
Add: {CurrentSection}
Where Current/Previous/Next Section is replaced with the text of the that section such as "Sounds" "Tile sets" "Sprites", etc etc.
I also rearranged the MenuItem_*** methods to be alphabetically ordered. Which has created some visual clutter in this Pr which I probably should have avoided >.< oops, hah. First time trying to do a PR on github, so I guess I'm learning. hah