More asset types for the "Find all references" feature (and more).#2179
Open
VladiStep wants to merge 14 commits intoUnderminersTeam:masterfrom
Open
More asset types for the "Find all references" feature (and more).#2179VladiStep wants to merge 14 commits intoUnderminersTeam:masterfrom
VladiStep wants to merge 14 commits intoUnderminersTeam:masterfrom
Conversation
… for "Find all references", add `UndertaleGameObject.FindChildren()`.
|
Download the artifacts for this pull request here: GUI:
CLI: |
…formant), fix previously broken indentation.
…name "Room object instances".
VladiStep
force-pushed
the
moreGameObjReferences
branch
from
f46f18b to
a776596
Compare
…et lists that may contain `null`s.
VladiStep
changed the title
This reverts commit 88ecebe.
…d more: 1) When there is a results window for the asset, it will be replaced when you search its references the second time. 2) Added `ShowReferencesFor()` method when you need to pre-select the types and start searching programmatically.
Member
Author
|
Hm, one check failed due to some upload error. |
Member
Author
|
I just made a minor change to re-run the checks. |
VladiStep
force-pushed
the
moreGameObjReferences
branch
from
2e73fef to
804091d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added the "Find all references" feature support for the following types:
- Fonts (in texture groups).
Improved the feature support for the following types:
- Game objects - added new "Game objects (children)" type; added
UndertaleGameObject.FindChildren()method.- Code - added new "Room object instances" types (creation and/or pre-create code); renamed "Room object instances".
Added new
IList<>.SkipNullItems()extension (e.g. for asset lists).Improved null asset filtering in the "Find all references" code.
Added the ability to pre-select the referenceable types and search for the asset references programmatically -
ShowReferencesFor()method.Added "Show children game objects" button to the game object editor.
The internal
argumentsvariable is not shown in "Unreferenced assets" - fixes Add an option to hide the "arguments" from "Find unreferences assets". #2148.Removed that big old commented chunk of code from "UndertaleGameObjectEditor.xaml".
Added
GameVersionrecord type.The "Find unreferenced assets" feature now shows only supported types, fixes The particle systems types are visible for GMS 1.0.0.1539. #1957.
GM LTS 2022.0 is treated as GM 2022.0.
Closes #2160.
Notes
I've already made a similar PR, but it's outdated because I also wanted to add a basic references in code support, but I didn't finish that, and recently, there were a lot of decompiler changes ("Underanalyzer").