Stuff for pksm-core G1&2 support #67
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diaz-esparza
pushed a commit
to diaz-esparza/pkmn-chest
that referenced
this pull request
May 20, 2025
Takes more of SNBeast's work for updating to a later version of PKSM-core, accomodating the change of the "personals" folder in nitrofs. Unsure of the exact purpose of this functionality/change. Props to SNBeast for the commits in Universal-Team#67, they are of great help, especially with me not knowing a whole lot about the dev tools.
diaz-esparza
pushed a commit
to diaz-esparza/pkmn-chest
that referenced
this pull request
Jun 25, 2025
Testing and integration of the rest of the code written in Universal-Team#67. The bugs have been tested, but not the solutions as of now, so more work needs to be done, either by save inspection on real hardware or by cross-referencing from the PKSM frontend. Changelog: - Tested and confirmed bugs on bag.cpp and trainer.cpp, yet to test proposed solutions by SNBeast - de-hardcoded fwrite nmemb, congruent with how PKSM saves pokemon. - added code for injecting pokemon in gens 1&2. - fixed lv 1 not existing and hatching @ lv 5 in gen 2 and 1 as it happens w/ gen 3 - enabled custom item id managing for < gen 3 - Japanese name issues (corroborated w/ PKSM codebase) Note: some other changes for the first commit of Universal-Team#67 were already merged in between the original PR and the making of this branch. I'm also not changing the save from a shared pointer into a unique pointer until I get the time and skill to check that it doesn't break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.