Fix/registration process #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

cisar2218 merged 5 commits into master from fix/registration_process

Feb 5, 2026

Contributor

cisar2218 commented Feb 4, 2026

Registration process updated, requirements from meeting implented:

Registration have to be approved by admin.
Firstname, lastname, email is required field in registration form.
Improved feedback when registration passes. @kaklik
Corresponding tests of the api auth endpoints added. Swagger docs also updated.

cisar2218 added 2 commits

February 4, 2026 13:44


          adding tests into workflows, .env.example update, readme contribution…

357006b

… setup update


          Add user approval workflow for registration

0fef57b

- Add mandatory fields on signup: email, first_name, last_name
- New users created with is_active=False (awaiting admin approval)
- Signup endpoint returns approval pending message without token
- SignupSuccessPage informs users about approval process
- Add corresponding tests for login with inactive/active users

github-code-quality bot found potential problems

View reviewed changes

backend/DOSPORTAL/tests/api/test_auth_endpoints.py Fixed Show fixed Hide fixed

backend/DOSPORTAL/tests/api/test_auth_endpoints.py Fixed Show fixed Hide fixed

cisar2218 added 3 commits

February 5, 2026 08:57


          code quality fixes in whole backend

d5bac6e


          code quality fixes in whole backend: unused variables

aab11d2


          code quality fixes in whole backend: start and unused imports, type c…

33f91e7

…hecking

github-code-quality bot found potential problems

View reviewed changes

backend/DOSPORTAL/views_record.py

                           # Create a new file name
-                          new_file_name = "new_" + original_file_name
+                          _new_file_name = "new_" + original_file_name

backend/DOSPORTAL/views_detectors.py

-                          text = form.cleaned_data['text']
-                          DetectorLogbook.objects.create(detector=detector, author=request.user, text=text)
+                          _text = form.cleaned_data['text']

backend/DOSPORTAL/views_record.py

    
                          new_file_name = data.pk

                          new_file_path = os.path.join(settings.MEDIA_ROOT, 'user_records', str(data.pk) )

                          _new_file_name = data.pk

backend/DOSPORTAL/views_record.py

    
                          new_file_name = data.pk

                          new_file_path = os.path.join(settings.MEDIA_ROOT, 'user_records', str(data.pk) )

                          _new_file_name = data.pk

                          _new_file_path = os.path.join(settings.MEDIA_ROOT, 'user_records', str(data.pk) )

backend/DOSPORTAL/views_record.py

    
                  minEnergy = request.GET.get('minEnergy', 'nan') # nan string je tu z duvodu, ze to je vychozi hodnota v js

                  maxEnergy = request.GET.get('maxEnergy', 'nan')

                  _minEnergy = request.GET.get('minEnergy', 'nan') # nan string je tu z duvodu, ze to je vychozi hodnota v js

backend/DOSPORTAL/views_record.py

    
                  minEnergy = request.GET.get('minEnergy', 'nan') # nan string je tu z duvodu, ze to je vychozi hodnota v js

                  maxEnergy = request.GET.get('maxEnergy', 'nan')

                  _minEnergy = request.GET.get('minEnergy', 'nan') # nan string je tu z duvodu, ze to je vychozi hodnota v js

                  _maxEnergy = request.GET.get('maxEnergy', 'nan')

cisar2218 merged commit ed2829d into master

7 checks passed

cisar2218 deleted the fix/registration_process branch

February 5, 2026 08:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet