Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SoccerGraphConverterPolarsthat is about 2x faster thanSoccerGraphConverter.SoccerGraphConverterPolarsSoccerGraphConverteras separate functionality, with a deprecation warning to move toSoccerGraphConverterPolarsAmericanFootballGraphConverter(which already had a Polars backend) with syntax used inSoccerGraphConverterPolarsChange Log
KloppyPolarsDataset
We introduce a
KloppyPolarsDatasetthat converts thekloppy_datasetto a Polars dataframe and does a number of conversions and checks. Use it as follows:ball_carrier_thresholdhas been moved toKloppyPolarsDatasetKloppyPolarsDatasetsets orientation toOrientation.BALL_OWNING_TEAM(ball owning team plays left to right). Except when we don't know who the ball owning team is. This can happen when a data provider does not provide the ball owning team information.ball_carrier_thresholdand subsequently change the orientation automatically to be left to right for the ball owning team too.Note: In
SoccerGraphConverterif the ball owning team was not available we set the orientation to STATIC_HOME_AWAY meaning attacking could happen in two directions. I felt this was undesirable.SoccerGraphConverterPolars
boundary_correctionhas been removed as a parameterinfer_ball_ownershiphas been removed as a parameter, this is now always handled automatically when necessaryinfer_goalkeepershas been removed as a parameter, this is now always handled automatically when necessary. If we have position labels (e.g. "GK") we use that.labels,graph_id,graph_idshave been removed as parameters. We can now uselabel_colandgraph_id_colas parameters, they default to "label" and "graph_id".