-
Notifications
You must be signed in to change notification settings - Fork 1
Add overengineered footer year #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for v1-platform failed.
|
LeonLiur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pages/index.tsx
Outdated
|
|
||
| useEffect(() => { | ||
| // fetch the year from advanced getyear api | ||
| fetch("https://getfulllyear.com/api/year") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is unfathamobly advanced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10x engineering here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my brother this is the wrong URL. it's "full" not "fulll" 😭
shrey150
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't actually merge this 😭 use Date() if you so desire
Status
READY/IN DEVELOPMENT/HOLD
Description
A few sentences describing the overall goals of the pull request's commits.
Related PRs
List related PRs against other branches:
Todos
Deploy Notes
Notes regarding deployment the contained body of work. These should note any
db migrations, etc.
Dependencies
Migrations
YES | NO
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
Impacted Areas in Application
List general components of the application that this PR will affect:
======================
Closes #[ISSUE NUMBER]