added revert to normal mode in case of bad sequence of selectionchang…#9889
Open
teslae1 wants to merge 2 commits intoVSCodeVim:masterfrom
Open
added revert to normal mode in case of bad sequence of selectionchang…#9889teslae1 wants to merge 2 commits intoVSCodeVim:masterfrom
teslae1 wants to merge 2 commits intoVSCodeVim:masterfrom
Conversation
J-Fields
reviewed
Jan 3, 2026
Member
Is there a way to detect this, and prevent it from changing the mode, rather than reverting it after the fact? |
Co-authored-by: Jason Fields <jasonfields4@gmail.com>
Author
I tried researching this (I agree it would be best to never end up in the bad state), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes mouseclick at eol when in normal mode sometimes triggers visual mode.
I was able to reproduce the problem - the core issue is that vscode
sometimes issues a specific sequence of selection change events on a single mouse click.
When the error occurs the sequence of events for the single mouse click is:
These two events leave the editor in the state which was also shown in
the issue: visual mode and no characters selected.
Which issue(s) this PR fixes
#9887