Skip to content

Fix regex grouping paren #9896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teslae1 wants to merge 2 commits into
base: master
Choose a base branch
from
+15 −1
Open

Fix regex grouping paren #9896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89fef59
added conversion to convert vim regex to js regex (without disturbing…
teslae1 Jan 9, 2026
b890ae2
added test to verify new functionality
teslae1 Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/vimscript/pattern.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,10 +305,13 @@ export class Pattern {
caseOverride,
ignoreSmartcase: args.ignoreSmartcase ?? false,
});

const jsPatternString = Pattern.convertToJsCompatiblePattern(patternString);

return new Pattern(
patternString,
args.direction,
Pattern.compileRegex(patternString, ignoreCase),
Pattern.compileRegex(jsPatternString, ignoreCase),
inSelection ?? false,
closed,
emptyBranch,
Expand All @@ -328,6 +331,10 @@ export class Pattern {
return configuration.ignorecase;
}

private static convertToJsCompatiblePattern(patternString: string): string {
return patternString.replace(/\\\(/g, '(').replace(/\\\)/g, ')');
}

private constructor(
patternString: string,
direction: SearchDirection,
Expand Down
7 changes: 7 additions & 0 deletions test/search/search.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,13 @@ suite('Search (/ and ?)', () => {
end: ['', 'one tw|o2o'],
});

newTest({
title: '/ can search with regex groupings (search for sequence of aX where X is not b)',
start: ['|', 'ab ac'],
keysPressed: '/a\\([^b]\\)\n',
end: ['', 'ab |ac'],
});

newTest({
title: '/ can search with newline',
start: ['|asdf', '__asdf', 'asdf'],
Expand Down