Clean stack for uninitialized variables inside GetKV3Defaults#5
Closed
vibecode2 wants to merge 4 commits intoValveResourceFormat:masterfrom
vibecode2:patch-1
Closed
Clean stack for uninitialized variables inside GetKV3Defaults#5vibecode2 wants to merge 4 commits intoValveResourceFormat:masterfrom vibecode2:patch-1
vibecode2 wants to merge 4 commits intoValveResourceFormat:masterfrom
vibecode2:patch-1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welp, another attempt, the way GetKV3Defaults works is it creates the schema class object on stack temporarily to dump the variables from it, but there are certain uninitialized variables that pick the values from dirty previous thread stack and never zeroes them out, so we force this clean up manually before calling GetKV3Defaults function
The uninitialized variables will just be 0