[All] env_projectedtexture - Fix texturename KV#1766
Open
SirYodaJedi wants to merge 1 commit intoValveSoftware:masterfrom
Open
[All] env_projectedtexture - Fix texturename KV#1766SirYodaJedi wants to merge 1 commit intoValveSoftware:masterfrom
texturename KV#1766SirYodaJedi wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
DEFINE_AUTO_ARRAY_KEYFIELD() doesn't currently properly handle keyvalue parsing, so it's better to just use DEFINE_AUTO_ARRAY() and manually parse the keyvalue in the KeyValues function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
texturenameKV doesn't work due to relying upon DEFINE_AUTO_ARRAY_KEYFIELD(), which doesn't handle keyvalue parsing correctly. While the macro could be fixed, it's hardly ever used (it's for C strings, whereas most KVs use string_t), and it's easier to just to manually handle parsing the KV in the KeyValues function, using DEFINE_AUTO_ARRAY() instead.This PR is similar to the fix that Portal 2 did, but was developed independently, referencing only SDK code.