Skip to content

fix:[#420] abort export if bin in $PATH#421

Draft
jardon wants to merge 1 commit intoVanilla-OS:mainfrom
jardon:fix/export-protection
Draft

fix:[#420] abort export if bin in $PATH#421
jardon wants to merge 1 commit intoVanilla-OS:mainfrom
jardon:fix/export-protection

Conversation

@jardon
Copy link
Member

@jardon jardon commented Oct 25, 2024

  • abort if bin or output in $PATH
  • en translation for abort message
$ ./apx snapcraft export -b ls
Error: Binary already exists on the host.
Usage:
  apx snapcraft export [flags]

Flags:
  -a, --app-name string     The name of the application to export.
  -b, --bin string          The name of the binary to export.
  -o, --bin-output string   Path of the binary output (default: ~/.local/bin/).
  -h, --help                help for export

  ERROR   Binary already exists on the host.

closes #420

- abort if bin or output in $PATH
- en translation for abort message
@jardon jardon requested a review from mirkobrombin October 25, 2024 11:23
@axtloss
Copy link
Contributor

axtloss commented Oct 25, 2024

We didn't agree on any way to solve the issue yet, currently there are multiple solutions proposed, we should wait until we agree on a solution first

@jardon jardon marked this pull request as draft October 25, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Exporting Podman breaks system

2 participants