Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,13 @@ coverage/

# Files generated by Mason
mason-lock.json
.mason
.mason

# Everyone should be free to customize
# AI assistants as they see fit.

.claude/
CLAUDE.local.md

.codex/
.cursor/
21 changes: 21 additions & 0 deletions AGENTS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Very Good Ventures

At its core, VGV prefers code that embodies clear, concise mental models. We prefer to think deeply about the problem we are solving and find the solution that best fits.

- Example 1: a file with many boolean variables might be implemented more cleanly as a state machine (using a bloc, cubit, or other package/pattern).
- Example 2: a file with a series of complex async operations may be better described as a series of stream transforms, an observable primitive, or even a composite.

If you recognize a key insight that would clean something up but do not have what you need on hand to implement it, please just say so. Adding a package reference is easy.

Our criteria for good code also enables us to achieve 100% test coverage.

Good code has...

- as few branches as possible
- injectable dependencies
- well-named identifiers
- no sibling dependencies in the same architectural layer

To avoid sibling dependencies, state must either be lifted up to a common ancestor and passed down, or pushed down and subscribed to.

See CONTRIBUTING.md for development details.
2 changes: 1 addition & 1 deletion test/helpers/command_helper.dart
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ void Function() _overridePrint(void Function(List<String>) fn) {
return () {
final printLogs = <String>[];
final spec = ZoneSpecification(
print: (_, _, _, String msg) {
print: (_, _, _, msg) {
printLogs.add(msg);
},
);
Expand Down
2 changes: 1 addition & 1 deletion test/src/commands/dart/commands/dart_test_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ void main() {
dartTest = _MockDartTestCommand();
testCommand = DartTestCommand(
logger: logger,
dartInstalled: ({required Logger logger}) async => isFlutterInstalled,
dartInstalled: ({required logger}) async => isFlutterInstalled,
dartTest: dartTest.call,
)..argResultOverrides = argResults;
when(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1095,7 +1095,7 @@ and limitations under the License.''');
veryGoodTestRunnerConfigPackage,
cliCompletionConfigPackage,
});
detectLicenseOverride = (String name, _) async {
detectLicenseOverride = (name, _) async {
final detectorResult = _MockResult();
final licenseMatch = name == veryGoodTestRunnerConfigPackage.name
? [mitLicenseMatch]
Expand Down Expand Up @@ -1142,7 +1142,7 @@ and limitations under the License.''');
veryGoodTestRunnerConfigPackage,
cliCompletionConfigPackage,
});
detectLicenseOverride = (String name, _) async {
detectLicenseOverride = (name, _) async {
final detectorResult = _MockResult();
final licenseMatch = name == veryGoodTestRunnerConfigPackage.name
? [mitLicenseMatch]
Expand Down Expand Up @@ -1191,7 +1191,7 @@ and limitations under the License.''');
veryGoodTestRunnerConfigPackage,
cliCompletionConfigPackage,
});
detectLicenseOverride = (String name, _) async {
detectLicenseOverride = (name, _) async {
final detectorResult = _MockResult();
final licenseMatch = name == veryGoodTestRunnerConfigPackage.name
? [mitLicenseMatch]
Expand Down Expand Up @@ -1315,7 +1315,7 @@ and limitations under the License.''');
veryGoodTestRunnerConfigPackage.name: [mitLicenseMatch],
cliCompletionConfigPackage.name: [bsdLicenseMatch],
};
detectLicenseOverride = (String name, _) async {
detectLicenseOverride = (name, _) async {
final detectorResult = _MockResult();
final licenseMatch = packageLicenseMatch[name]!;

Expand Down Expand Up @@ -1364,7 +1364,7 @@ and limitations under the License.''');
veryGoodTestRunnerConfigPackage.name: [mitLicenseMatch],
cliCompletionConfigPackage.name: [bsdLicenseMatch],
};
detectLicenseOverride = (String name, _) async {
detectLicenseOverride = (name, _) async {
final detectorResult = _MockResult();
final licenseMatch = packageLicenseMatch[name]!;

Expand Down Expand Up @@ -1415,7 +1415,7 @@ and limitations under the License.''');
veryGoodTestRunnerConfigPackage.name: [mitLicenseMatch],
cliCompletionConfigPackage.name: [bsdLicenseMatch],
};
detectLicenseOverride = (String name, _) async {
detectLicenseOverride = (name, _) async {
final detectorResult = _MockResult();
final licenseMatch = packageLicenseMatch[name]!;

Expand Down
3 changes: 1 addition & 2 deletions test/src/commands/test/test_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,7 @@ void main() {
flutterTest = _MockFlutterTestCommand();
testCommand = TestCommand(
logger: logger,
flutterInstalled: ({required Logger logger}) async =>
isFlutterInstalled,
flutterInstalled: ({required logger}) async => isFlutterInstalled,
flutterTest: flutterTest.call,
)..argResultOverrides = argResults;
when(
Expand Down
Loading