Feature Implementation and Code Quality Improvements#355
Merged
No0ne558 merged 3 commits intoViewTouch:masterfrom Jan 31, 2026
Merged
Feature Implementation and Code Quality Improvements#355No0ne558 merged 3 commits intoViewTouch:masterfrom
No0ne558 merged 3 commits intoViewTouch:masterfrom
Conversation
- Fixed off-by-one-cent issue in Order Entry zone total calculation - Changed from per-order tax summation to using pre-calculated SubCheck tax totals - Ensures Order Entry display matches actual check total exactly - Eliminates rounding differences between individual vs aggregated tax calculation This resolves the discrepancy where Order Entry would show a total different from the final check total when tax was applied.
- Added -Wno-system-headers and -Wno-maybe-uninitialized flags - Suppresses warnings from external date library chrono.h headers - Project now builds completely clean with no compiler warnings
- Standardized all header guards to use _FILENAME_HH format consistently - Fixed mismatches between #ifndef and #define directives across 25+ header files - Added missing header guards to video_zone.hh - Updated zone/ and main/ui/ directories for consistent compilation - All header guards now follow the pattern: #ifndef _FILENAME_HH / #define _FILENAME_HH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements an out-of-stock toggle feature for menu items and resolves several code quality issues including tax calculation bugs and compiler warnings.
Changes Made
1. Tax Calculation Fix (
871a0af)2. External Library Warning Suppression (
6a51150)-Wno-system-headersand-Wno-maybe-uninitializedflags to CMakeLists.txt3. Header Guard Standardization (
2c02538)_FILENAME_HHformat consistentlyFeatures Implemented
Out-of-Stock Toggle Feature
out_of_stockboolean field toSalesItemclassTesting
Files Changed
main/business/sales.*- Added out-of-stock field and serialization29 header files- Standardized header guard formatBreaking Changes
None. All changes are backward compatible.
Related Issues
Ready for review and merge! 🚀
This PR enhances the ViewTouch POS system with new functionality while maintaining high code quality standards.