VCST-4632: Fix NRE when resolving empty brands catalog#86
Open
ksavosteev wants to merge 1 commit intodevfrom
Open
VCST-4632: Fix NRE when resolving empty brands catalog#86ksavosteev wants to merge 1 commit intodevfrom
ksavosteev wants to merge 1 commit intodevfrom
Conversation
|
vc-ci
reviewed
Feb 17, 2026
Contributor
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.543
Timestamp: 17-02-2026T13:09:51
OlegoO
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
References
QA-test:
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-4632
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.XCatalog_3.946.0-pr-86-0806.zip
Note
Low Risk
Small null-safety fix in brand search; main risk is DI/registration mismatch due to the new
ICatalogServicedependency.Overview
Fixes a null-reference scenario in
SearchBrandQueryHandlerwhen no brand categories are returned by resolving the catalog directly via a newICatalogServicefallback.This updates the handler constructor to accept and store
ICatalogService, then uses it to fetch the brands catalog whenbrandCategories.FirstOrDefault()?.Catalogis null.Written by Cursor Bugbot for commit 08066f4. This will update automatically on new commits. Configure here.