fix: add inverse crosshair when set axes inverse#3989
Open
LonelySnowman wants to merge 2 commits intoVisActor:developfrom
Open
fix: add inverse crosshair when set axes inverse#3989LonelySnowman wants to merge 2 commits intoVisActor:developfrom
LonelySnowman wants to merge 2 commits intoVisActor:developfrom
Conversation
Contributor
Author
Contributor
Author
|
@xuanhun 辛苦抽空帮忙 review 下这个 PR。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🤔 这个分支是...
🔗 相关 issue 链接
Fixed #3973
🔗 相关的 PR 链接
None
🐞 Bugserver 用例 id
Badcase:
💡 问题的背景&解决方案
直方图 axes 设置反向后, 由于 bandSize 设置了 Math.abs 导致 crossHair 没有正确渲染。对
axis.getInverse() && axis.type === ComponentTypeEnum.cartesianLinearAxis进行反向处理。📝 Changelog
☑️ 自测
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough