Merged
Conversation
dragonmantank
requested changes
Dec 19, 2025
Member
dragonmantank
left a comment
dragonmantank
left a comment
There was a problem hiding this comment.
Just one thing, avoid a request if we don't have to make it.
|
|
||
| options = IdentityInsightsRequest( | ||
| phone_number="1234567890", | ||
| insights=InsightsRequest(format=EmptyInsight()) |
Member
There was a problem hiding this comment.
This would be one of those things where we should be able to fail sale early - it makes no sense to send an empty request, so we should save the HTTP request and just throw the proper exception.
Contributor
Author
There was a problem hiding this comment.
Not sure if I follow you. Identity Insights needs to include a explicit empty object in the request for some insights (format, carrier information, roaming and reachability).
dragonmantank
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.