Fix issue WP-API/OAuth1#59, OAuth callback isn't called#84
Fix issue WP-API/OAuth1#59, OAuth callback isn't called#84sblaz wants to merge 1 commit intoWP-API:masterfrom
Conversation
|
I had an issue with this. I had to do a rawurldecode() on the callback before saving it to make this work. |
|
Hmm, indeed, I think this patch applied by itself is insufficient to get the callback working. I also had some issues with double-encoding of the oauth_callback parameter value. Applied #65 and then removed the two rawurlencode() calls in join_with_equals_sign() and was good to go. The url decoding stuff all seems to happen earlier in normalize_parameters() |
|
In my case, normalize_parameters() is really messing up my already partially encoded parameters, so by removing normalize_parameters() instead, I was able to keep the rawurldecode() calls. See: #91 I have created a PR which merges your changes with AlexC's and removes normalize_parameters() in favor of encoding them in the join_with_equals_sign() function: #92 |
|
Thanks for the PR! This is already applied in a separate spot; is this not working for you? |
|
Closing out; this should be fixed, and in any case, this PR no longer applies as a lot of the code has been rewritten. Thanks anyway! |
No description provided.