Improve Leaf Record Errors

[ds5678]

No description provided.

[Washi1337]

I like the idea, but I think if we want to capture the unknown / unsupported type records, then we should be consistent with this and use it everywhere. E.g., SerializedArrayTypeRecord could benefit from the same type of construction.

However, simply replacing code like this with a call to the proposed GetLeafRecord method loses contextual information if an error occurs. E.g., there is a difference between a message such as SerializedArrayTypeRecord contains an incorect leaf type at index 01234. and Array type 5678 contains an invalid element type index 1234.. The second one is more specific, since it also indicates which property failed to be parsed, rather than simply stating that some index within the leaf was invalid. Furthermore, the first does not include the type index of the faulty leaf itself either.

Can we somehow rephrase / refactor this such that we do not lose this contextual information?

[ds5678]

How do you want to handle the SerializedArrayTypeRecord situation?

[Washi1337]

@ds5678 The array type record was just an example of how a leaf could reference multiple type indices, and thus it would be unclear in the error message of the proposed change which type index was invalid.

Some simple idea would be to add a string parameter to the GetLeafRecord method, indicating which type index was attempted to be looked up, so it could be used in the error string format. I am open for other ideas as well though.