Classic/TBC/Wrath: add groupRole and fetchRole to BuffTrigger2#6128
Merged
InfusOnWoW merged 1 commit intoWeakAuras:mainfrom Jan 18, 2026
Merged
Classic/TBC/Wrath: add groupRole and fetchRole to BuffTrigger2#6128InfusOnWoW merged 1 commit intoWeakAuras:mainfrom
InfusOnWoW merged 1 commit intoWeakAuras:mainfrom
Conversation
Contributor
|
If I recall correctly from the last time I looked at this, the api exist, but the user interface doesn't. Which seemed to indicate that the feature would be more confussing then useful for classic |
Contributor
Author
|
I've tested this now on Classic, and as well on TBC and Wrath and can confirm that the user interface exists and is fully functional alongside the API. |
InfusOnWoW
approved these changes
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds
groupRoleandfetchRolesupport to BuffTrigger for Classic/TBC/Wrath.The functionality is already used in other triggers and code paths; this change mainly aligns BuffTrigger2 with existing behavior for consistency.
Role detection is based on the standard WoW API:
UnitGroupRolesAssigned
I tested this mainly for availability to ensure it works correctly in Classic/TBC/Wrath.
Type of change
Checklist