Skip to content

Fix decodeAudioData algorithm logic#2665

Merged
padenot merged 1 commit intomainfrom
2637-decodeaudiodata-jump
Jan 20, 2026
Merged

Fix decodeAudioData algorithm logic#2665
padenot merged 1 commit intomainfrom
2637-decodeaudiodata-jump

Conversation

@padenot
Copy link
Member

@padenot padenot commented Jan 16, 2026

Per WG resolution 2025-05-15:

  • Step 3 condition now correctly says "is not detached" instead of "is detached"
  • Step 3.2 now correctly jumps to step 4.1 (error handling) if the ArrayBuffer detach operation throws

Also fixed "this operations" -> "this operation" typo while I was there.

This fixes #2637 and fixes #2646.


Preview | Diff

Per WG resolution 2025-05-15:
- Step 3 condition now correctly says "is not detached" instead of
  "is detached"
- Step 3.2 now correctly jumps to step 4.1 (error handling) if the
  ArrayBuffer detach operation throws

Also fixed "this operations" -> "this operation" typo.

This fixes #2637 and fixes #2646.
@padenot padenot requested a review from hoch January 16, 2026 14:35
@padenot padenot merged commit 69c40d2 into main Jan 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

decodeAudioData step 3 has the test inverted BaseAudioContext decodeAudioData typo

2 participants