Skip to content

feat: Enhance Attribute and Message annotations with improved generics support for better type safety.#600

Open
Yi-pixel wants to merge 1 commit intoWebklex:masterfrom
Yi-pixel:master
Open

feat: Enhance Attribute and Message annotations with improved generics support for better type safety.#600
Yi-pixel wants to merge 1 commit intoWebklex:masterfrom
Yi-pixel:master

Conversation

@Yi-pixel
Copy link

This helps development tools (like PhpStorm and PHPStan) correctly recognize the return types of these methods.

@Yi-pixel
Copy link
Author

This PR still has a few issues that need to be addressed.

  • Attribute::first uses the reset function, which causes an empty array to return false instead of the expected null. So we need to confirm whether we should change the implementation of first, or adjust the code in the local PR instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant