Conversation
|
|
Some of these check failures don't look right. It is also checking READMEs. |
|
| uses: karancode/yamllint-github-action@master | ||
| with: | ||
| yamllint_file_or_dir: 'charts/whatsapp-proxy-chart/*/*' | ||
| yamllint_file_or_dir: 'charts/whatsapp-proxy-chart/*/*.yml' |
There was a problem hiding this comment.
Yeah we need to add *.yaml here as well because almost all of our files are .yamls.
There was a problem hiding this comment.
Thinking about it more, I'm pretty sure helm charts actually fail yamllint, since the interpolation isn't yaml standard. I don't think we can use this, we'll need to do a helm lint instead per sbaudoin/yamllint#16 (comment)
There was a problem hiding this comment.
We should use https://github.com/helm/chart-testing-action instead. Although neither of these would catch the procotcl misspelling error, as there's no defined spec for it. It'd catch invalid formatting, but not invalid keys.
No description provided.