Fix jq healthcheck to account for nulls#370
Merged
peixian merged 1 commit intoWhatsApp:mainfrom Apr 15, 2025
Merged
Conversation
facebook-github-bot
added
the
CLA Signed
eozturk1
approved these changes
Apr 15, 2025
Contributor
eozturk1
left a comment
eozturk1
left a comment
There was a problem hiding this comment.
Can we also test a failing case as well?
Member
Author
|
Failing case |
|
Unsubscribe
Pada tanggal Sel, 15 Apr 2025 21.52, Peixian Wang ***@***.***>
menulis:
… Merged #370 <#370> into main.
—
Reply to this email directly, view it on GitHub
<#370 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A37ML62ZEJ7RLVSQKUFAKOL2ZUMMRAVCNFSM6AAAAAB3BSXIPOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJXGI3TCMJVGY3TEOI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
q |
| # Select the "check_desc" field (Description of the check result) | ||
| # and take all results that do NOT equal "Layer4 check passed" from HAProxy | ||
| RESULT=$(tail -n +1 /tmp/stats.txt | jq -R 'split(",")' | jq -c '. | select(.[1] | contains("whatsapp_net"))' | jq --raw-output '.[65]| select(. | test("Layer4 check passed") | not)') | ||
| RESULT=$(tail -n +1 /tmp/stats.txt | jq -R 'split(",")' | jq -c 'select(.[1] != null) | select(.[1] | contains("whatsapp_net"))' | jq --raw-output '.[65]| select(. | test("Layer4 check passed") | not)') |
| @@ -11,7 +11,7 @@ curl -s -w 2 "http://127.0.0.1:8199/;csv" > /tmp/stats.txt || exit 1 | |||
| # Filter out the lines for *.whatsapp_net backend status | |||
| # Select the "check_desc" field (Description of the check result) | |||
| # and take all results that do NOT equal "Layer4 check passed" from HAProxy | |||
| # Filter out the lines for *.whatsapp_net backend status | ||
| # Select the "check_desc" field (Description of the check result) | ||
| # and take all results that do NOT equal "Layer4 check passed" from HAProxy | ||
| RESULT=$(tail -n +1 /tmp/stats.txt | jq -R 'split(",")' | jq -c '. | select(.[1] | contains("whatsapp_net"))' | jq --raw-output '.[65]| select(. | test("Layer4 check passed") | not)') |
There was a problem hiding this comment.
|
El sáb, 15 de nov de 2025, 19:20, dylanreyes0457-ux <
***@***.***> escribió:
… ***@***.**** commented on this pull request.
------------------------------
In proxy/src/healthcheck.sh
<#370 (comment)>:
> @@ -11,7 +11,7 @@ curl -s -w 2 "http://127.0.0.1:8199/;csv" > /tmp/stats.txt || exit 1
# Filter out the lines for *.whatsapp_net backend status
# Select the "check_desc" field (Description of the check result)
# and take all results that do NOT equal "Layer4 check passed" from HAProxy
-RESULT=$(tail -n +1 /tmp/stats.txt | jq -R 'split(",")' | jq -c '. | select(.[1] | contains("whatsapp_net"))' | jq --raw-output '.[65]| select(. | test("Layer4 check passed") | not)')
+RESULT=$(tail -n +1 /tmp/stats.txt | jq -R 'split(",")' | jq -c 'select(.[1] != null) | select(.[1] | contains("whatsapp_net"))' | jq --raw-output '.[65]| select(. | test("Layer4 check passed") | not)')
proxy-main.zip
<https://github.com/user-attachments/files/23564853/proxy-main.zip>
—
Reply to this email directly, view it on GitHub
<#370 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BYTPOEAUPVYD4VIM2DTWHRL3467MFAVCNFSM6AAAAAB3BSXIPOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTINRYG44DKNJXGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
andysaputraa2025-web
approved these changes
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This healthcheck has been broken for a while now, although I think we usually just don't notice it.
How this started
I noticed that we were seeing pretty frequent healthcheck errors when this got deployed
However, the pods themselves were clearly healthy, so this was very odd, and manual inspection of pod metrics made it look okay, and WA was clearly not down.
Debugging
On a pod:
nullhere implies an odd value, and indeed we can see that by selecting the raw fields{"field1":null,"isNull":true}is our problem.By skipping over nulls:
We can see that this health check now succeeds:
Hasn't this been around forever?
Yep. Which meant that pods sometimes would get restarted in kubernetes for random reasons. I suspect the root cause is that when HAproxy gets a lot of load, the stats file becomes slightly different, which adds this null value. We should switch to prometheus based metrics for health checks when they're available.