Fix for #292 and changed filenamelimit#293
Conversation
|
PR not ok? Anything I should change before merging? Please note that build fails due to other reasons, see https://travis-ci.org/WikiTeam/wikiteam/builds. |
| class TestDumpgeneratorOffline(unittest.TestCase): | ||
|
|
||
| def setUp(self): | ||
| other = dict() # FIXME: get from dumpgenerator, but code base is a pre-OO mess |
There was a problem hiding this comment.
+1 for inspirational quote. Wonderful poetry that summarizes dumpgenerator.py in a single sentence.
There was a problem hiding this comment.
hehe, sry, could not resist ;)
I was pretty discouraged after giving up to get the configuration out of dumpgenerator.py :(
Hydriz
left a comment
There was a problem hiding this comment.
Your change looks good, but the test case that you implemented does not seem to be picked up by Travis CI. Can you have a look at that?
|
Thanks for your feedback @Hydriz. For me it looks like the build fails due to other reasons? The PR introduces |
|
I'll test this in the upcoming days. Make now any change you want me to test! |
See #292. Any comments are welcome.